Eliminate use of child docs in documentation #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
reviewed
Apr 23, 2024
There was a problem hiding this comment.
In that case it'd be nice to update https://pkgdown.r-lib.org/reference/build_site.html?q=footer#page-layout to not refer to the sidebar, or to refer to the correct docs page.
See also #2490
|
I'll fix #2490, then do a pass through all the docs and send it to you for review. |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
The only file that was actually used in multiple places was sidebar-configuration.Rmd, but I don't think it actually belongs in customise.Rmd with navbar and footer because it only affects a single page. Fixes r-lib#2367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only file that was actually used in multiple places was
sidebar-configuration.Rmd, but I don't think it actually belongs incustomise.Rmdwithnavbarandfooterbecause it only affects a single page.Fixes #2367